Reorganise plot rendering #6665
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a pet peeve of mine: the build method(s) don't read very nicely.
First off,
ggplot_build()
andggplot_gtable()
are in the same file, which is messy because they are both user-facing functions, they do things independently and are also documented separately.Secondly, I understand why
ggplot_build()
is hard to read: it is complicated.However,
ggplot_gtable()
has a lot of gtable operation complexity, which can be easily hidden away in some choice helper functions. It becomes a lot simpler to understand whatggplot_gtable()
is doing if the steps are separate functions.